Historic Scotland’s flagship attraction Edinburgh Castle is celebrating after welcoming its one millionth visitor through the door this year. No , they haven’t had one million visitors since January 1 . This is their financial year which ends in March